-
Notifications
You must be signed in to change notification settings - Fork 4.2k
test(buzz-acp): pin the explicit-publish delivery contract in base_prompt.md - #7429
Open
tmtz1 wants to merge 1 commit into
Open
test(buzz-acp): pin the explicit-publish delivery contract in base_prompt.md #7429tmtz1 wants to merge 1 commit into
tmtz1 wants to merge 1 commit into
Conversation
...ompt.md A stray local edit to base_prompt.md (never committed) replaced the correct instruction with a false one: 'The Buzz bridge publishes your completed response automatically... Do not run `buzz messages send` yourself.' No code path turns a completed ACP turn's text into a published relay event — handle_session_update's agent_message_chunk arm only logs it (acp.rs) — so every agent reading that edited file silently dropped any reply that didn't explicitly invoke the CLI. Confirmed live against Terri's session: a plain-text health probe produced a correctly-delivered agent_message_chunk on the wire that buzz-acp received and discarded, exactly as the code predicts. base_prompt.md itself needed no edit — its committed content was already correct; only the on-disk working copy differed. This adds a regression test pinning the correct contract and asserting the false claim can't return.
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...3684bb37abae30f1f9dcd730f57c09380eb17cff.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 3684bb37abae30f1f9dcd730f57c09380eb17cffto authorize a new review.
Any previous review applies only to its recorded range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A local, uncommitted edit to
crates/buzz-acp/src/base_prompt.md(never part of any commit, found sitting in a shared checkout) had replaced the correct delivery instruction with a false one: "The Buzz bridge publishes your completed response automatically... Do not runbuzz messages sendyourself."No code path in
buzz-acpturns a completed ACP turn's text into a published relay event —handle_session_update'sagent_message_chunkarm only logs it (acp.rs). Sincebase_prompt.mdis read fresh from disk at process startup (BUZZ_ACP_BASE_PROMPT_FILE, not compiled into the binary), any agent process that started while the false text was in place silently dropped every reply that didn't explicitly invoke the CLI.Confirmed live in production: raised log verbosity on one affected agent's service, sent a plain-text health probe, and watched the agent correctly emit the response as an
agent_message_chunkthat the bridge received and discarded exactly as the code predicts.Changes
base_prompt.mdneeded no edit — its committedHEADcontent was already correct. This PR does not touch it.shared_base_prompt_requires_explicit_publish_not_implicit_bridge_deliveryincrates/buzz-acp/src/lib.rs, asserting the correct contract text is present and the false claim can't return.Test plan
buzz-acpcrate suite: 900 passed, 0 failedpool_lifecycle_stateintegration suite: 9/9 passedHEADNo merge requested — opened for review/preservation per team direction. No BirdieFit source, credentials, or the deployed binary were touched.