-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(desktop): store Windows secrets per credential - #7416
Open
KKandFRIENDS wants to merge 1 commit into
Open
Conversation
Signed-off-by: Kiseok Kim <kim.kiseok.1969@gmail.com>
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...5d43ee6ae177f1c77a6db1ac592847f74ba2a420.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 5d43ee6ae177f1c77a6db1ac592847f74ba2a420to authorize a new review.
Any previous review applies only to its recorded range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Windows Credential Manager limits a credential blob to 2,560 bytes. Aggregating many managed-agent nsec values into one JSON credential exceeds that limit and forces secrets to remain inline.
Safety properties
Test plan
cargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkcargo check --manifest-path desktop/src-tauri/Cargo.tomlcargo test --manifest-path desktop/src-tauri/Cargo.toml --lib— 3,010 passed, 0 failed, 19 ignoredcargo test --manifest-path desktop/src-tauri/Cargo.toml windows_ -- --ignored— 4 Windows Credential Manager tests passedThe Windows integration coverage includes 40 independently stored nsec-shaped values, legacy migration, stale-legacy cleanup, delete-one isolation, and full-reset deletion.