-
Notifications
You must be signed in to change notification settings - Fork 4.2k
test(pair-relay): drop self-declared duplicate test_cancellation_immediate - #7403
Open
rebekz wants to merge 1 commit into
Open
test(pair-relay): drop self-declared duplicate test_cancellation_immediate #7403rebekz wants to merge 1 commit into
rebekz wants to merge 1 commit into
Conversation
Remove test_cancellation_immediate, which upstream documents as an explicit duplicate of test 9 and implements identically. test_120s_timeout remains the canonical virtual-time coverage. Signed-off-by: Fitra Kacamarga <fitra.19@gmail.com>
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...c03757a1591b2479f45b22954248cdf6f109da78.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review c03757a1591b2479f45b22954248cdf6f109da78to authorize a new review.
Any previous review applies only to its recorded range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_cancellation_immediateincrates/buzz-pair-relay/tests/integration.rsflakes under parallel load and passes in isolation.It is a duplicate — and the source says so itself:
In practice even the "different assertion style" is not different. Both tests are identical:
start_relay,connect,advance(121s),yield_now,assert_closed. The name is also misleading — it tests a 120-second timeout, not immediate cancellation.Fix
Delete the duplicate.
test_120s_timeout(test 9) remains the canonical virtual-time coverage, so no coverage is lost.Verification
test_120s_timeoutpasses after the deletion, exit 0. Nothing else in the file is touched.Note, not addressed here
The same file declares another self-described duplicate a few lines below:
/// 43. ... Explicit duplicate of test 34 with a different connection state.Left alone deliberately to keep this patch minimal — flagging it in case it is also worth pruning.
🤖 Generated with Claude Code