-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix(mobile): discover owned agents without runtime advertisements - #7395
Draft
loganj wants to merge 1 commit into
Draft
fix(mobile): discover owned agents without runtime advertisements #7395loganj wants to merge 1 commit into
loganj wants to merge 1 commit into
Conversation
Signed-off-by: Logan Johnson <loganj@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Stack / rollout
Base: #7393 (
fix/mobile-authorization-20260905). 311 added + deleted lines, including tests. Closest related: #7393/#7394.Do not enable widened discovery until publication #7394 and explicit invitations #7390 are integrated. This is a rollout gate, not a code dependency. All PRs remain draft.
Validation
just mobile-checkandjust mobile-testpass on the source committed as5dcc5dea(2,099 tests).just ciendedRESULT:1: 913/915 ACP tests passed; unchangedkeepalive_resets_idle_past_deadlineandidle_resets_on_stdout_activityfailed. The later ACP unit lane passed, but this is not a full-local-CI pass. GitHub Mobile passes at5dcc5dea.Desktop reference:
desktop/src-tauri/src/commands/agent_discovery/relay_directory.rs(owner-coordinate seed + authenticated exact-policy resolution).Originating Buzz channel:
f6cfbbe2-3f94-4b41-9105-e6dcc5459813; request9c1c48d4b47b390d88434d623d08c697275e7af9c20884715f44bf42b45c0edf.Composed-stack evidence / landing note
Current review head:
5dcc5deaf80626aea9f2ff62141792eaa91ec3bb; incremental size: 311 added + deleted lines.All 11 draft slices are composed on
verify/mobile-combined-20260905at40630565:just mobile-checkand the fulljust mobile-testpass (2,144 tests). This is integration evidence, not a twelfth review PR or native-device acceptance.Independent branches overlap, especially in the composer. Use that commit as the conflict-resolution reference when rebasing for landing; do not blindly choose one branch’s send function. Preserve exact/durable bindings, explicit Invite/reference-only intent, visit/account/community/revision fences, and authorization before membership preparation and before publication. Widened discovery must not roll out before #7390 + #7394 are integrated. Code dependency is only the declared PR base; overlapping files and rollout order are not extra dependency edges.
All PRs remain draft; no merge requested. Security/human review is not complete. Originating Buzz channel:
f6cfbbe2-3f94-4b41-9105-e6dcc5459813.