-
Notifications
You must be signed in to change notification settings - Fork 634
Return version from package.json on CLI, fixes #415 and bitpay/bitcore#1368#533
Open
kingjan1999 wants to merge 1 commit intobitpay:master from
Open
Return version from package.json on CLI, fixes #415 and bitpay/bitcore#1368 #533kingjan1999 wants to merge 1 commit intobitpay:master from
kingjan1999 wants to merge 1 commit intobitpay:master from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One might argue that reading version numbers from package.json isn't good style and may have security implications (https://stackoverflow.com/a/10855054), but I don't see any problems here.
This fixes #415 and should fix bitpay/bitcore#1368 (though I haven't tested the latter).