-
Notifications
You must be signed in to change notification settings - Fork 634
Open
Conversation
and make sure there is an error if the arch is unknown
kreshendo
kreshendo
approved these changes
Oct 7, 2016
kreshendo
commented
Oct 11, 2016
When will this be merged?
l2inilbzone
l2inilbzone
approved these changes
Feb 11, 2017
metaspartan
metaspartan
approved these changes
Jun 16, 2017
@bitjson
bitjson
force-pushed
the
master
branch
from
August 18, 2017 23:21
b7f83a0 to
7e34c41
Compare
Any word on if this will ever be merged? Would solve a lot of problems for us ubuntu/mac/vagrant users! Its been approved, why was the merge not processed?
vagrant@vagrant-ubuntu-trusty-32:~$ npm install -g bitcore-node
\
> bitcore-node@3.1.3 preinstall /home/vagrant/.nvm/versions/node/v4.8.4/lib/node_modules/bitcore-node
> ./scripts/download
Downloading bitcoin: https://github.com/bitpay/bitcoin/releases/download/v0.12.1-bitcore-4/
npm ERR! Linux 3.13.0-119-generic
npm ERR! argv "/home/vagrant/.nvm/versions/node/v4.8.4/bin/node" "/home/vagrant/.nvm/versions/node/v4.8.4/bin/npm" "install" "-g" "bitcore-node"
npm ERR! node v4.8.4
npm ERR! npm v2.15.11
npm ERR! code ELIFECYCLE
npm ERR! bitcore-node@3.1.3 preinstall: `./scripts/download`
npm ERR! Exit status 22
npm ERR!
npm ERR! Failed at the bitcore-node@3.1.3 preinstall script './scripts/download'.
npm ERR! This is most likely a problem with the bitcore-node package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! ./scripts/download
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs bitcore-node
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR! npm owner ls bitcore-node
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/vagrant/npm-debug.log
vagrant@vagrant-ubuntu-trusty-32:~$ uname -i
i686
ScriptProdigy
ScriptProdigy
approved these changes
Oct 4, 2017
metaspartan
commented
Oct 4, 2017
Let's keep making it known! Approve this PR Bitcore devs!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix download script for i686 and make sure there is an error if the arch is unknown
closes: bitpay/bitcore#1423 (comment)