-
-
Notifications
You must be signed in to change notification settings - Fork 163
Open
Conversation
bitbrain
commented
Apr 11, 2026
Owner
@Clicky-coded could you extend the existing blackboard unit test to have a simple test for this?
bitbrain
bitbrain
requested changes
Apr 11, 2026
@bitbrain
bitbrain
left a comment
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test required
Clicky-coded
commented
Apr 11, 2026
Author
I dont think i will be able to write a unit test for some time as I do not know gdunit and am busy with other stuff
bitbrain
commented
Apr 12, 2026
Owner
@Clicky-coded it's fairly easy, see https://github.com/bitbrain/beehave/blob/godot-4.x/test/blackboard/blackboard_test.gd basically just 4-5 lines where you call the method and verify it works.
Unfortunately, I cannot accept pull requests without test coverage, as beehave has very high quality standards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will close #435