-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor domain record services to canonical PipelineService naming#1404
Open
bgembalczyk wants to merge 1 commit into
Open
Refactor domain record services to canonical PipelineService naming #1404bgembalczyk wants to merge 1 commit into
bgembalczyk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
*PipelineServiceand remove the genericDomainRecordServicealias used broadly.DomainRecordService = ...alias by adding a static test.Description
scrapers/services/domain_record/{driver,constructor,circuit,season}_adapter.pythat export the canonical*PipelineServiceand input DTOs.scrapers/services/domain_record/base_adapter.pyas the canonical base adapter type and keptbase_pipeline_service.pyas a deprecated shim that emits aDeprecationWarning.DriverPipelineService,ConstructorPipelineService,CircuitPipelineService, andSeasonPipelineService, and updated call sites and typing in composition factories and single-scraper entrypoints.tests/test_domain_record_service_alias_policy.pythat fails CI ifDomainRecordService = ...assignments are introduced outside the designated transition module.Testing
pytest -q tests/test_domain_record_service_alias_policy.pyand the new AST policy test passed.python -m compileall -qover the changed modules and compilation succeeded.pytest -q tests/scrapers/circuits/test_domain_record.py tests/test_single_scraper_components_and_orchestration.py tests/test_domain_record_service_alias_policy.pybut test collection failed in this environment due to a missing external dependency (ModuleNotFoundError: No module named 'layers.path_resolver').Codex Task