-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
SyedFahad7
commented
Mar 3, 2026
Please rebase your PR branch onto the latest develop (do not merge develop into your feature branch).
Try:
git fetch upstream
git rebase upstream/develop
Resolve conflicts and run local checks (npm run lint, npm run build)
git push --force-with-lease origin <your-branch>
Notes:
No need to fix unrelated pre-existing warnings.
Do fix errors introduced by your PR (especially in touched files).
This rebases only your PR branch; it does not rewrite our develop branch.
Also raise the PR against develop branch and not main @GandrothuNagaSaiRishitha
GandrothuNagaSaiRishitha
commented
Mar 4, 2026
@SyedFahad7 ill do it, please excuse me for this inconvinence.
8623e49 to
21c8d53
Compare
@SyedFahad7
SyedFahad7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @GandrothuNagaSaiRishitha . The tool implementation is substantial and constants wiring is mostly done, and build/lint checks are generally fine on my side.
I am requesting changes for two blockers before merge:
1.Please add the tool entry in app/libs/developmentToolsConstant.tsx for slug html-to-jsx-converter. The slug page currently destructures metadata directly, so missing entry can break runtime rendering.
2. Event attributes like onclick currently convert to onClick as a quoted string value, which is not valid React handler usage in normal TSX flows. Please adjust conversion behavior for inline event handlers.
Non-blocking: please align formatting in constants sections for consistency with surrounding code.
Once these are fixed, I can re-review quickly.
Description
Adds a new HTML to JSX Converter tool that allows React developers to convert
standard HTML snippets into valid JSX syntax instantly.
Changes made:
app/components/developmentToolsComponent/htmlToJsxConverter.tsx— the converter componentapp/libs/constants.tsx(import, PATHS, category, route)Fixes #20
Dependencies
No new dependencies added. Uses existing packages already in the project:
@monaco-editor/react(already in package.json)antd(already in package.json)@phosphor-icons/react(already in package.json)Future Improvements
Mentions
Resolves the issue assigned to @GandrothuNagaSaiRishitha
Developer's checklist
##Additional Information:
If feature found okay, please merge under apertre 3.0 label and appropriate difficulty labels