Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Hide VTX menu when feature is unavailable #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haslinghuis merged 1 commit into betaflight:master from atomgomba:hide-vtx-menu
Oct 19, 2023

Conversation

Copy link
Contributor

@atomgomba atomgomba commented May 25, 2023

This is one more step in handling the absence of VTX tables, completely hiding the option in the main menu would make scrolling a tiny bit more convenient and the user won't have to wait a few seconds for no reason just to see "N/A" when clicking on VTX menu.

Also I'm not sure if this is a good solution, I was thinking about potentially being able to hide options for other features as well (e. g. some users might have no GPS or OSD and we could hide those too, or whatever optional feature may come up in the future). Hiding the VTX menu alone would require a simpler logic, hence less new lines added.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

Copy link

github-actions bot commented Jul 3, 2023

Pull request closed automatically as inactive.

Copy link

Pull request closed automatically as inactive.

Copy link

Pull request closed automatically as inactive.

Copy link
Contributor Author

Pull request closed automatically as inactive.

Bad bot

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

Copy link
Contributor Author

Please accept this during Hacktoberfest :P

haslinghuis reacted with laugh emoji

Copy link
Member

Have to ask the organizer @asizon 😂

asizon reacted with laugh emoji

Copy link
Member

asizon commented Aug 22, 2023

Lol, we need the Lua master here @klutvott123

haslinghuis reacted with laugh emoji

Copy link
Contributor Author

just out of curiosity, why is this stalled? any objections? @klutvott123

@haslinghuis haslinghuis merged commit 70f5e47 into betaflight:master Oct 19, 2023
atomgomba added a commit to atomgomba/betaflight-tx-lua-scripts that referenced this pull request Oct 20, 2023
Copy link

@atomgomba It would be nice if they could implement this for the OSD and GPS page as well. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Make VTX Tables optional for digital video systems (no VTX option for firmware cloud build)

AltStyle によって変換されたページ (->オリジナル) /