Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Skip vtx tables download if not available #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haslinghuis merged 3 commits into betaflight:master from klutvott123:skip-vtx-table
Mar 13, 2023

Conversation

Copy link
Member

@klutvott123 klutvott123 commented Mar 12, 2023
edited
Loading

Use msp error bit to determine if message is available in firmware or not. Pass msp error to the layer above so that we can take action if there's an error.
The FC will still respond if for example MSP_VTX_CONFIG isn't available, but the msp over telemetry error bit will be set and the payload is an error code. We can use this to detect if the firmware has been compiled with VTX support, and skip vtx tables download if not.

Fixes #474

betaflight-tx-lua-scripts_1.7.0.zip

TheIsotopes reacted with thumbs up emoji haslinghuis reacted with rocket emoji
Copy link
Member Author

Added the message "N/A" that will replace the content of the page if it can't be loaded. Updated first post with new zip file if anyone wants to try it.

Copy link

@klutvott123
for the osd elements page there should also be a query as to whether the firmware was compiled with osd.
lua scripts must be ended with long RTN because an error message appears.

Copy link
Member Author

Where exactly does this error message appear? And what does it say?

MSP_OSD_CONFIG isn't wrapped in "#IF defined(USE_OSD) like it should have been, so it will return something even if the firmware is compiled without OSD. This means we can't detect it in the same way as for vtx and gps rescue for example. The way it's done in the firmware is very inconsistent between messages. it's annoying and we should look into it

haslinghuis reacted with thumbs up emoji

Copy link

here the sreenshot from error:

screen-2023年03月12日-230014

Copy link
Member Author

@TheIsotopes And this is without OSD, OSD_SD and OSD_HD?

Copy link

klutvott123 reacted with thumbs up emoji

Copy link
Member Author

Thanks! will look into it.

TheIsotopes reacted with thumbs up emoji

Copy link

Tested and working properly although I did notice that for analog, the second load is a little bit faster. Tested with my previous work around of creating the files manually and that prevents the VTX table check making the load time a bit faster for digital video systems.

Copy link
Member Author

@TomAlperin Thanks for testing. I made it so that it creates a empty vtx table if not available. This will make it skip future download attempts
betaflight-tx-lua-scripts_1.7.0.zip

Copy link
Member Author

@haslinghuis haslinghuis merged commit d900131 into betaflight:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

+1 more reviewer

@TheIsotopes TheIsotopes TheIsotopes approved these changes

Reviewers whose approvals may not affect merge requirements
Projects
Status: COMPLETED
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Waiting for VTX Tables

AltStyle によって変換されたページ (->オリジナル) /