-
-
Notifications
You must be signed in to change notification settings - Fork 154
Fix string writes to board info table #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
haslinghuis
merged 1 commit into
betaflight:master
from
klutvott123:fix-string-write-to-file
Dec 17, 2021
Merged
Fix string writes to board info table #412
haslinghuis
merged 1 commit into
betaflight:master
from
klutvott123:fix-string-write-to-file
Dec 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
haslinghuis
approved these changes
Dec 17, 2021
TheIsotopes
commented
Dec 17, 2021
Tested again, now everything works as expected.
thx @klutvott123
SteveCEvans
SteveCEvans
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no LUA expert, but this is simple to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Forgot to wrap the strings with "" when writing them to file. This makes it fail on legacy targets where manufacturer id is an empty string.
Thanks @TheIsotopes for noticing and reporting this!
Test version
betaflight-tx-lua-scripts_1.5.0.zip
Fixes #411