-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Automatically upload build artifacts to github release #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+84
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes #700 and fixes #801 in 959f7df by triggering the build.yml workflow when a new release is tagged and switching to the
houseabsolute/actions-rust-releaseaction for handling uploading build artifacts, thesoftprops/action-gh-releaseaction is used to upload the build artifact to the github release for the tag. For workflow runs where there is no tag (e.g when a PR is merged to master branch), the upload to the github release is skipped.All that is required to trigger this workflow, is the creation of a github release which creates a new git tag, everything else should happen automatically. If you wish to see a preview of the format of the build artifacts you can check on my branch here: https://github.com/gizmoguy/RustScan/actions/runs/20584298010, and a preview of the assets created on the github release can be seen here: https://github.com/gizmoguy/RustScan/releases/tag/2.4.1
In this PR I have also fixed a few other CI issues I noticed, such as a38c74d should fix the failing dependabot.yml workflow failures (No event triggers defined in
on) for every event, e.g: https://github.com/bee-san/RustScan/actions/runs/20519668212ab4ea8a fixes the deprecation warning (The
set-outputcommand is deprecated and will be disabled soon) for the test.yml workflow, e.g: https://github.com/bee-san/RustScan/actions/runs/205196686432f7026c bumps the versions of the various github actions used throughout the workflows to their latest respective versions