-
Notifications
You must be signed in to change notification settings - Fork 382
Open
Conversation
jakobhellermann
commented
Feb 8, 2026
Author
yagebu
commented
Feb 12, 2026
Member
Thanks for opening a PR. I think the fix here needs to be to have different colors for the different texts:
- the legend is on the background, which is different in dark and light mode - so these texts also need to adjust
- the chart colors are the same in dark and light, so the text color there should probably stay the same as well
jakobhellermann
commented
Mar 15, 2026
Author
Okay I changed the PR to only apply the new text-on-chart color for the icicle and treemap charts, and keep the rest as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2215
Dark:
image
image
Light:
image
image