-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
ed080c7 to
991ef27
Compare
ahumesky
commented
Jan 13, 2026
Looks like there're some issues on CI but I think this is a nice change we should get in
agluszak
commented
Jan 13, 2026
WORKSPACE seems uncooperative unfortunately, I'll first figure out how to handle these problems in rules_kotlin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Apps shouldn't need to declare dependencies that are used by the rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another way to pass this flag to the underlying proto rules/actions? This line assumes that the user's app depends on protobuf directly, which might not be the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need protobuf in the Maven deps if you're replacing their references with @com_google_protobuf?
ted-xie
commented
Jan 14, 2026
@agluszak Thanks for this PR! It definitely moves us in the right direction towards reducing our CI times.
If you wouldn't mind, I'd really prefer this PR to be split into two pieces:
- Migrate rules_android's protobuf-related deps entirely to
@com_google_protobufto eliminate the possibility of protobuf runtime vs dependency library mismatch errors (this is becoming increasingly toilsome to maintain) - Use prebuilt protoc
No description provided.