Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow passing keystore password other than android#426

Open
snazhmudinov wants to merge 1 commit into
bazelbuild:main from
snazhmudinov:sherozn/make-keystore-password-configurable
Open

Allow passing keystore password other than android #426
snazhmudinov wants to merge 1 commit into
bazelbuild:main from
snazhmudinov:sherozn/make-keystore-password-configurable

Conversation

@snazhmudinov

@snazhmudinov snazhmudinov commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

@ahumesky @ted-xie can you check this one?

),
keystore_signing_password = attr.string(
doc = """
The password for the KeyStore that contains the signer's key and certificate.

@snazhmudinov snazhmudinov Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

cc: @meisterT

ahumesky commented Dec 2, 2025

Copy link
Copy Markdown
Collaborator

I'm not sure that this is good idea because it could appear to encourage checking passwords into source control since this goes into a build file. In general with bazel (and internally with blaze) signing outputs is handled outside of the build system (besides the debug key in the case of android).

Copy link
Copy Markdown
Contributor Author

I'm not sure that this is good idea because it could appear to encourage checking passwords into source control since this goes into a build file. In general with bazel (and internally with blaze) signing outputs is handled outside of the build system (besides the debug key in the case of android).

Yes, I was having in mind the password for the debug keystore. If that's okay, where would the logic go?

@snazhmudinov snazhmudinov force-pushed the sherozn/make-keystore-password-configurable branch from 1b7f9c1 to 91fecd5 Compare December 3, 2025 06:23

Copy link
Copy Markdown
Contributor Author

@ahumesky any thoughts on the last comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /