Feature/allow different delimiters for sed and prettify labels #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

EmilyGraceSeville7cf wants to merge 5 commits into bash-lsp:main from EmilyGraceSeville7cf:feature/allow-different-delimiters-for-sed

Closed

Feature/allow different delimiters for sed and prettify labels #913

EmilyGraceSeville7cf wants to merge 5 commits into bash-lsp:main from EmilyGraceSeville7cf:feature/allow-different-delimiters-for-sed

Conversation

EmilyGraceSeville7cf

Copy link

Contributor

@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Jul 16, 2023

allow | delimiter for sed commands
use - instead of : in labels

EmilySeville7cfg added 5 commits

July 17, 2023 02:33


 feat(snippets): support vertical line delimiter

660d4c9


 feat(snippets): don't use colon in labels

aaff81d


 Merge branch 'main' into feature/allow-different-delimiters-for-sed

3220e38


 feat(snippets): fix escaping

7cfb503


 Merge branch 'feature/allow-different-delimiters-for-sed' of https://...

e971a3b

...github.com/EmilySeville7cfg/bash-language-server into feature/allow-different-delimiters-for-sed

@skovhus

Copy link

Collaborator

skovhus commented Jul 16, 2023

Thanks!

use - instead of : in labels

Curious what the reason behind this change. Is that more standard?

@EmilyGraceSeville7cf

Copy link

Contributor Author

EmilyGraceSeville7cf commented Jul 17, 2023

Curious what the reason behind this change. Is that more standard?

This change reflects this comment. Actually there is no standard here AFAIK. You can meet spaces in labels too.

I am thinking about replacing - with spaces. But I don't know whether Vim/Emacs will be okay with such snippets. @Shane-XB-Qian, do you know anything about this? Is it fine to have spaces for snippets used in Vim/Emacs?

@Shane-XB-Qian

Copy link

Contributor

Shane-XB-Qian commented Jul 17, 2023 via email

I am thinking about replacing `-` with spaces. But I don't know whether Vim/Emacs will be okay with such snippets. @Shane-XB-Qian, do you know anything about this? Is it fine to have spaces for snippets used in Vim/Emacs?

i preferred `_` (underscore) (though `-` maybe workable) IF snips have to store in server.

...

-- shane.xb.qian