@otreblan thanks for adding this! 👏 Do you have time to add a few unit tests? That would be great.

@otreblan thanks for adding this! clap Do you have time to add a few unit tests? That would be great.

Done

Another thing: updating the triggerCharacters configuration option (line 107 in src/server.ts) to include - makes it work without additional configuration.

When - is in triggerCharacters:

Should it work when editing sh file (with #!/usr/bin/env bash) in neovim started from zsh? I have installed bash-completion package with homebrew, but it does not provide completions on find -. bashls updated to 2.0.0 and iskeyword contains - (45).

Should it work when editing sh file (with #!/usr/bin/env bash) in neovim started from zsh? I have installed bash-completion package with homebrew, but it does not provide completions on find -. bashls updated to 2.0.0 and iskeyword contains - (45).

Do you have bash-completion@1 or bash-completion@2?

Version 1. Works with @2, thank you! Although I am only getting completions for find, none for head or sort, as per video above. Using native nvim LSP client.

Version 1. Works with @2, thank you! Although I am only getting completions for find, none for head or sort, as per video above. Using native nvim LSP client.

image

I see, there is no completions for those in /usr/local/share/bash-completion/completions/. Commands with completions there do work fine. Great job, thanks!

Hi, I can't find any documentation on this feature in the README.

I have the following installed, and it works with find - [tab tab] on the command line:

Installed Packages
Name : bash-completion
Epoch : 1
Version : 2.7
Release : 5.el8
Architecture : noarch
Size : 895 k
Source : bash-completion-2.7-5.el8.src.rpm
Repository : @System
From repo : anaconda
Summary : Programmable completion for Bash
URL : https://github.com/scop/bash-completion
License : GPLv2+
Description : bash-completion is a collection of shell functions that take advantage
 : of the programmable completion feature of bash.

It does not seem to work in Neovim using the default config for the LSP https://github.com/neovim/nvim-lspconfig/blob/master/CONFIG.md#bashls and https://github.com/hrsh7th/nvim-cmp . Can anyone help? Thanks.

npm ls -g --depth=0
/usr/local/lib
├── bash-language-server@2.0.0

@David-Else Whats the output of pkg-config --variable=datadir bash-completion?

@otreblan The result is nothing, just an empty line. Also echo $BASH_COMPLETION gives an empty line too.

@David-Else Does your installation has /usr/share/pkgconfig/bash-completion.pc?

@otreblan yes:

$ls /usr/share/pkgconfig/
total 48K
drwxr-xr-x. 2 root root 4.0K Aug 16 11:42 .
drwxr-xr-x. 233 root root 12K Jul 21 09:17 ..
(various files)
-rw-r--r--. 1 root root 292 Apr 12 01:35 bash-completion.pc

@David-Else And it's contents?

@otreblan

bat /usr/share/pkgconfig/bash-completion.pc 
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 │ File: /usr/share/pkgconfig/bash-completion.pc
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 1 │ prefix=/usr
 2 │ compatdir=/etc/bash_completion.d
 3 │ completionsdir=${prefix}/share/bash-completion/completions
 4 │ helpersdir=${prefix}/share/bash-completion/helpers
 5 │ 
 6 │ Name: bash-completion
 7 │ Description: programmable completion for the bash shell
 8 │ URL: https://github.com/scop/bash-completion
 9 │ Version: 2.7
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Am I still meant to add autocmd FileType sh set iskeyword+=45, I assumed that was fixed somewhere in this PR?

@David-Else Your bash-completion is too old, datadir was added 2 years ago https://github.com/scop/bash-completion/blame/master/bash-completion.pc.in

@otreblan Cheers! I will try to update using the source from Github, I am using Rocky Linux 8, and they do have some out of date things hidden in there.

@otreblan Hello again. I removed my old Centos 8 RPM version of bash-completion and installed the latest from source. Now my bash-completion.pc is installed in /usr/local/share/pkgconfig and says:

prefix=/usr/local
datadir=/usr/local/share
sysconfdir=/usr/local/etc
compatdir=${sysconfdir}/bash_completion.d
completionsdir=${datadir}/bash-completion/completions
helpersdir=${datadir}/bash-completion/helpers
Name: bash-completion
Description: programmable completion for the bash shell
URL: https://github.com/scop/bash-completion
Version: 2.11

I am still not getting auto completion in neovim. You asked me before did I have /usr/share/pkgconfig/bash-completion.pc, now the file has moved could that be the problem? Thanks.

EDIT pkg-config --variable=datadir bash-completion still shows nothing

@otreblan Thanks to the new 2.1 version it now works! :)

This feature works in Helix, but there is a problem. It does not happen in Neovim, can it be solved here or should I make a request to the Helix devs? If so, what should I ask them to implement? Cheers!

1. Type find - and ctrl-x to trigger autocomplete:
   Screenshot from 2023年01月04日 17-27-58

2. Select depth

Screenshot from 2023年01月04日 17-28-01

3. Now you are left with the original - that should not be there, it should be -depth not --depth

Screenshot from 2023年01月04日 17-28-03

@David-Else it seems like a Helix issue as it works in all other clients. And I'm honestly not sure what the issue is.

@skovhus Thanks for the quick reply!