-
Notifications
You must be signed in to change notification settings - Fork 137
Shebang handling #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shebang handling #156
Conversation
At the moment this PR merges only the current master into shebang-handling.
See #47
A bit hard to read this PR. Could we rebase the changes on top of master instead of merging?
Do not restrict it with this condition.
TODO
- review (I am beginner with TS-specific things)
- allow to pass glob pattern in another way than using an environment variable
- more tests
- allow the user to disable scanning working dir against bash/sh shebang
- give
hasBashShebangonly the first line of the file (do not match the entire content)
Sorry for stalling here. I've investigated the issue, and it turns out that all bash files (that VS Code can detect) are handled just fine. We don't need to read all the files in a project–unless we want to do just to definition across files (required more work).
It seemed to be natural that the results of analyzeing the rest of scripts are accessible for completion and jumping. Indeed: at the moment there is no need to make (almost?) unusable index.
It seemed to be natural that the results of analyzeing the rest of scripts are accessible for completion and jumping. Indeed: at the moment there is no need to make (almost?) unusable index.
My mistake. It is indeed used for indexing. #47 (comment) 👍
@przepompownia thanks for your work here. We now handle most of the cases here – except for reading all files.
I'm reluctant to implement parsing all the files in a project, that shouldn't be necessary. We might consider adding parsing all files without extensions though. :)
No description provided.