-
Notifications
You must be signed in to change notification settings - Fork 136
Remove npm install step from VS Code extension #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mads-hartmann can you try it out by uninstalling bash-language-server (npm -g uninstall bash-language-server) and run:
cd vscode-client && vsce package --yarn
code --install-extension <path to package.vix>
Closed
@skovhus Just gave it a go. It works 🎉
@mads-hartmann we should release the vscode extension :)
The version number is bumped, so we just need to run the release step. Can you do that?
@skovhus Done, works like a charm 🎉
NICE! <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Here we are removing the npm install step by including the new wasm version of the LSP server into the VS Code extension.
I combined some work I did back in June (https://github.com/mads-hartmann/bash-language-server/pull/134/commits) and work done a year ago (#72).
Related to #131
TODO
Note on how to test: