-
Notifications
You must be signed in to change notification settings - Fork 137
Update release-client.sh script #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't actually have a way to test this, but I think it should be okay
If you disagree with this, feel free to close, but I thought it might be a good idea 😄
Thanks for reviewing!
This comment was marked as outdated.
This comment was marked as outdated.
Update vscde to latest version (vsce is depresated in favor of @vscode/vsce) Add --skip-duplicate flag, this allows us to fail silently if the version already exists on the marketplace, which was why we had the "|| echo" before, but it also hid real failures, so IMO this is a better way to handle that Also update snapshot, since I moved `tagRelease` to the next line, one of the tests failed
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 81.52%. Comparing base (
f8b202b) to head (d272cb2).
Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1155 +/- ## ======================================= Coverage 81.52% 81.52% ======================================= Files 28 28 Lines 1348 1348 Branches 320 320 ======================================= Hits 1099 1099 Misses 204 204 Partials 45 45
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Update vscde to latest version (vsce is depresated in favor of @vscode/vsce)
The current code has an
|| echothat masks failures from vsce publish, in order to not fail the pipeline when the published version already exists.The latest version of vsce adds a --skip-duplicate flag, this allows us to fail silently if the version already exists on the marketplace, so IMO this is a better way to handle that