-
Notifications
You must be signed in to change notification settings - Fork 137
Only analyze files that end with .sh in their names #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip out on trying to parse directories that have a .sh suffix in their names. Otherwise, the language server will crash when trying to read a directory as a file. Signed-off-by: Remy Suen <remy.suen@gmail.com>
Signed-off-by: Remy Suen <remy.suen@gmail.com>
Thanks! There is a formatting issue. To fix it you can run yarn lint
I thought we had a pre-commit for this.
@skovhus (I think) I have made the necessary changes. The build looks green now.
Is there anything else I need to address to move this forward?
@rcjsuen thanks for reminding me. 👍
Yzrsah
commented
Mar 19, 2019
@rcjsuen thank you
@Yzrsah Happy to help. Seemed like a straightforward enough of a thing to fix. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102.
Skip out on trying to parse directories that have a
.shsuffix in their names. Otherwise, the language server will crash when trying to read a directory as a file.