Implementation of fuse lowlevel, ls cd mkdir rmdir. #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ibwroot wants to merge 3 commits into baidu:master

from ibwroot:fuse_lowlevel_

Open

Implementation of fuse lowlevel, ls cd mkdir rmdir. #849

ibwroot wants to merge 3 commits into baidu:master from ibwroot:fuse_lowlevel_

Conversation

@ibwroot

Copy link

Contributor

@ibwroot ibwroot commented Feb 12, 2017

No description provided.

ibwroot added 2 commits

February 12, 2017 20:46

@ibwroot


 Implemetation of fuse lowlevel, ls cd mkdir rmdir. supporting single ...

9f9d9b3

...NS only.
(baidu#315)
(baidu#660)

@ibwroot


 Merge branch 'fuse_lowlevel' into fuse_lowlevel_

29ad18f

Conflicts:
	src/nameserver/namespace.h
	src/sdk/fs_impl.cc

yvxiang

yvxiang reviewed

Feb 20, 2017

View reviewed changes

fuse_lowlevel/bfs_ll_mount.cc Outdated

static int reply_buf_limited(fuse_req_t req, const char *buf, size_t bufsize,

off_t off, size_t maxsize) {

if (bufsize - off > 0)

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码风格

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/nameserver/namespace.cc Outdated

//unfinshed, consistency not guranteed, to be continue

bool NameSpace::DeleteFileInfo(const std::string file_key, NameServerLog* log) {

int64_t entry_id;

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到使用时再声明吧

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/nameserver/namespace.cc Outdated

LOG(INFO, "path split fail %s", path.c_str());

return kBadParameter;

}

LOG(INFO, "path split %s", path.c_str());

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进好像有问题

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/nameserver/namespace.cc Outdated

return kBadParameter;

}

LOG(INFO, "path split %s", path.c_str());

LOG(INFO, "path[0] %s", paths[0].c_str());

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥单独把path[0]打出来

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 这一行忘了删掉了

src/nameserver/namespace.cc Outdated

s = db_i->Write(leveldb::WriteOptions(), &batch);

if (!s.ok()) {

LOG(INFO, "Unlink dentry fail: %s\n", dir_info.name().c_str());

LOG(FATAL, "Namespace write to db_i fail!");

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥连着打两行

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/sdk/bfs.h Outdated

};

struct BfsFileInfo {

uint64_t ino;

Copy link

Collaborator

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

接口里都是用的int64_t

Copy link

Contributor Author

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对,这个地方我想把proto fileinfo entry_id,及namespace的有关接口统一改成uint64_t,因为fuse lowlevel端的ino参数的类型是unsigned long

@ibwroot


 Coding style and remove unused debug log.

feb03a0

(baidu#315)
(baidu#660)

@ibwroot ibwroot force-pushed the fuse_lowlevel_ branch from 47733e5 to feb03a0 Compare

February 21, 2017 07:18

Labels

None yet

2 participants

@ibwroot @yvxiang

Implementation of fuse lowlevel, ls cd mkdir rmdir. #849

Are you sure you want to change the base?

Implementation of fuse lowlevel, ls cd mkdir rmdir. #849

Uh oh!

Conversation

@ibwroot ibwroot commented Feb 12, 2017

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@yvxiang yvxiang Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

@ibwroot ibwroot Feb 20, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants