Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

misc: Fix https://github.com/aylei/leetcode-rust/issues/3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tinycedar wants to merge 1 commit into aylei:master
base: master
Choose a base branch
Loading
from tinycedar:master

Conversation

Copy link

@tinycedar tinycedar commented Mar 20, 2019

No description provided.

Copy link
Owner

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel, do you think it would be better if user can choose the leetcode site?

const PROBLEMS_URL: &str = "https://leetcode.com/api/problems/algorithms/";
const GRAPHQL_URL: &str = "https://leetcode.com/graphql";
const PROBLEMS_URL: &str = "https://leetcode-cn.com/api/problems/algorithms/";
const GRAPHQL_URL: &str = "https://leetcode-cn.com/graphql";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a command line argument to override the hostname?

Copy link
Author

@tinycedar tinycedar Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll add it

aylei reacted with thumbs up emoji
Cupnfish added a commit to Cupnfish/leetcode-rust that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /