-
Notifications
You must be signed in to change notification settings - Fork 443
Conversation
|
🍕 Here are the new binary sizes!
|
@iamhopaul123
iamhopaul123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great and thank you for contributing! Just wanted to double check: have you tested this feature locally and verified you would be able to build images using podman after this change? Or is there anything else that needs to be done for the full workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like we should have a different function for podman push (same signature as Push it's just with a different name), so that we don't need to change the function signature and also the push function is quite different when the engine type is podman.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider this, but it seems like there's still a lot of shared functionality that would be a pain to update in multiple places.
The alternative could be to build a new type PodmanCmdClient that implements ContainerLoginBuildPusher by just calling the existing methods - but again that seemed to add more complexity than it removed.
ammerzon
commented
Jan 25, 2024
@mjrlee, are there any updates on this, or do you need support? 😁
mjrlee
commented
Feb 13, 2024
Sorry, I haven't had much time to look at this recently.
I can confirm I'm currently using it with podman and it's working well.
I've resolved a couple of comments on the PR, and replied to another.
Adds a new "engine" build argument that can be used to handle podman's different way of handing image digests.
Fixes #3170
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.