-
Notifications
You must be signed in to change notification settings - Fork 191
Simplify native code configurations and aes_ctr_set_key#3019
Simplify native code configurations and aes_ctr_set_key #3019torben-hansen wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'aes_hw_ctr32_encrypt_blocks_wrapper'; did you mean 'aes_hw_ctr32_encrypt_blocks'? [clang-diagnostic-error]
Additional context
crypto/fipsmodule/aes/internal.h:96: 'aes_hw_ctr32_encrypt_blocks' declared here
void aes_hw_ctr32_encrypt_blocks(const uint8_t *in, uint8_t *out, size_t len, ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'vpaes_encrypt_wrapper' [clang-diagnostic-error]
*out_block = vpaes_encrypt_wrapper; ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'vpaes_encrypt_wrapper' [clang-diagnostic-error]
CRYPTO_gcm128_init_key(gcm_key, aes_key, vpaes_encrypt_wrapper, 0); ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: use of undeclared identifier 'vpaes_ctr32_encrypt_blocks_wrapper'; did you mean 'vpaes_ctr32_encrypt_blocks'? [clang-diagnostic-error]
Additional context
crypto/fipsmodule/aes/internal.h:240: 'vpaes_ctr32_encrypt_blocks' declared here
void vpaes_ctr32_encrypt_blocks(const uint8_t *in, uint8_t *out, size_t len, ^
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #3019 +/- ## ========================================== + Coverage 78.31% 78.33% +0.02% ========================================== Files 689 689 Lines 121007 120988 -19 Branches 16996 16994 -2 ========================================== + Hits 94765 94776 +11 + Misses 25346 25316 -30 Partials 896 896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.