Skip to content

Navigation Menu

Sign in
Sign up

Update aws-lambda-cpp to 0.2.7 - #67

Open
tl-hbk wants to merge 2 commits into
aws:main from
tl-hbk:aws-lambda-cpp_0.2.7
Open

Update aws-lambda-cpp to 0.2.7 #67
tl-hbk wants to merge 2 commits into
aws:main from
tl-hbk:aws-lambda-cpp_0.2.7

Conversation

@tl-hbk

@tl-hbk tl-hbk commented Feb 7, 2022

Copy link
Copy Markdown

Was having the following issue when building awslabs/aws-lambda-cpp#93 which is fixed in aws-lambda-cpp 0.2.7

The following patches were deleted as they were already merged upstream in aws-lambda-cpp

  • aws-lambda-cpp-make-the-runtime-client-user-agent-overrideable.patch - Commit
  • aws-lambda-cpp-make-lto-optional.patch - Commit

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tl-hbk commented Feb 7, 2022
edited
Loading

Copy link
Copy Markdown
Author

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken
https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

Copy link
Copy Markdown
Contributor

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

Thanks for pointing out, it's been addressed.

Copy link
Copy Markdown
Contributor

Thank you for your contribution! It looks like deps/versions is conflicting with a recent libcurl update, would you mind resolving the conflict?

tl-hbk commented May 4, 2022

Copy link
Copy Markdown
Author

@zsombor-balogh resolved the conflict

tl-hbk commented May 5, 2022

Copy link
Copy Markdown
Author

Build errors seem to be related to this
awslabs/aws-lambda-cpp#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@zsombor-balogh zsombor-balogh zsombor-balogh approved these changes
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /