-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url
https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken
https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working
EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz
zsombor-balogh
commented
May 4, 2022
Unrelated but when I ran
update_deps.shthe download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the urlhttps://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working
EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz
Thanks for pointing out, it's been addressed.
zsombor-balogh
commented
May 4, 2022
Thank you for your contribution! It looks like deps/versions is conflicting with a recent libcurl update, would you mind resolving the conflict?
# Conflicts: # deps/versions
tl-hbk
commented
May 4, 2022
@zsombor-balogh resolved the conflict
tl-hbk
commented
May 5, 2022
Build errors seem to be related to this
awslabs/aws-lambda-cpp#124
Was having the following issue when building awslabs/aws-lambda-cpp#93 which is fixed in aws-lambda-cpp 0.2.7
The following patches were deleted as they were already merged upstream in aws-lambda-cpp
aws-lambda-cpp-make-the-runtime-client-user-agent-overrideable.patch- Commitaws-lambda-cpp-make-lto-optional.patch- CommitBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.