-
Notifications
You must be signed in to change notification settings - Fork 84
[Performance] Reduce unnecessary copying of strings and objects - #129
Open
marcomagdy wants to merge 1 commit into
Open
[Performance] Reduce unnecessary copying of strings and objects #129marcomagdy wants to merge 1 commit into
marcomagdy wants to merge 1 commit into
Conversation
This patch attempts to improve performance by doing the following: 1. Remove an extra `getenv` call, which internally involve a bunch of string copying. 2. Avoid default constructing the `invocation_request` object only to overwrite it later with the actual request. Instead use a reference. 3. Avoid copying the request string when we can pass it by reference Testing: - make test - make test-integ
marcomagdy
marked this pull request as ready for review
November 28, 2023 20:05
marcomagdy
commented
Nov 28, 2023
Author
FWIW, I wrote the native the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch attempts to improve performance by doing the following:
getenvcall, which internally involve a bunch of string copying.invocation_requestobject only to overwrite it later with the actual request. Instead use a reference.Testing:
Target (OCI, Managed Runtime, both):
Both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.