-
Notifications
You must be signed in to change notification settings - Fork 242
Open
Conversation
@SentryMan
SentryMan
changed the title
(削除) Add module descriptor with moditect (削除ここまで)
(追記) Add module descriptor to core module with moditect (追記ここまで)
Sep 3, 2024
@SentryMan
SentryMan
changed the title
(削除) Add module descriptor to core module with moditect (削除ここまで)
(追記) #142 Add module descriptor to core module with moditect (追記ここまで)
Sep 3, 2024
@SentryMan
SentryMan
changed the title
(削除) #142 Add module descriptor to core module with moditect (削除ここまで)
(追記) #142 Add module descriptors with moditect (追記ここまで)
Sep 4, 2024
smirnoal
smirnoal
approved these changes
Sep 13, 2024
maxday
maxday
reviewed
Sep 16, 2024
SentryMan
commented
Nov 22, 2024
Author
SentryMan
commented
Nov 3, 2025
Author
man this is taking quite some time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Issue #, if available:
resolves #142
Description of changes:
Uses moditect maven plugin to add a
module-info.classwithout breaking Java 8 compatibility.Target (OCI, Managed Runtime, both):
Both
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.