-
Notifications
You must be signed in to change notification settings - Fork 578
lambda: return a copy of the pooled response buffer from Invoke - #639
Open
lenamonj wants to merge 1 commit into
Open
lambda: return a copy of the pooled response buffer from Invoke #639lenamonj wants to merge 1 commit into
lenamonj wants to merge 1 commit into
Conversation
codecov-commenter
commented
Sep 7, 2026
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.38%. Comparing base (6800157) to head (69471fa).
Additional details and impacted files
@@ Coverage Diff @@ ## main #639 +/- ## ======================================= Coverage 82.38% 82.38% ======================================= Files 36 36 Lines 1419 1419 ======================================= Hits 1169 1169 Misses 247 247 Partials 3 3
☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handlerFunc.Invokereturnsresponse.Bytes()from a pooled*jsonOutBufferafter its deferredClose()has reset it and returned it to the pool, so the caller holds a slice of pooled storage that the next invoke overwrites in place. Two sequential calls onNewHandler(func(s string) (string, error) { return s, nil })show it: once the second returns"BBBB", the first result reads"BBBB"too.Function.Invokeon the net/rpc path assigns the same slice toresponse.Payload.The fix returns a copy. The new test fails on main as described and passes with the change.
go test -race ./lambda/is otherwise unchanged and golangci-lint v2.13.1 reports no issues.