-
Notifications
You must be signed in to change notification settings - Fork 578
feat(events): add LinkParameter to CognitoEventUserPoolsCustomMessageRequest (fixes #592) - #627
Open
nghiack7 wants to merge 1 commit into
Open
feat(events): add LinkParameter to CognitoEventUserPoolsCustomMessageRequest (fixes #592) #627nghiack7 wants to merge 1 commit into
nghiack7 wants to merge 1 commit into
Conversation
...Request The AWS Cognito Custom Message trigger documentation shows a linkParameter field in the request payload for verification link scenarios (CustomMessage_VerifyUserAttribute, CustomMessage_AdminCreateUser). This field was missing from the Go struct, forcing users to unmarshal into a custom type or use json.RawMessage to access it. Fixes aws#592
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #592 —
linkParameteris missing fromCognitoEventUserPoolsCustomMessageRequest.The AWS Cognito Custom Message trigger documentation shows a
linkParameterfield in the request payload. This field is populated when theTriggerSourceisCustomMessage_VerifyUserAttributeorCustomMessage_AdminCreateUser, and contains the verification link placeholder for the email message.Without this field, users are forced to work around it:
json.RawMessageand parse manuallyChanges
events/cognito.go: AddedLinkParameter string(withomitempty) toCognitoEventUserPoolsCustomMessageRequestevents/testdata/cognito-event-userpools-custommessage.json: AddedlinkParameterexample value to the test fixtureTest plan
go test ./events/ -run TestCognitopasses — round-trip JSON test verifieslinkParameterunmarshals and re-marshals correctlygo test ./events/full events package passes with no regressions