-
Notifications
You must be signed in to change notification settings - Fork 578
feat<events.cognito>: add support for custom email sender - #419
feat<events.cognito>: add support for custom email sender #419BorisLeMeec wants to merge 4 commits into
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.66%. Comparing base (80c32f1) to head (3b3640c).
Additional details and impacted files
@@ Coverage Diff @@ ## main #419 +/- ## ======================================= Coverage 71.66% 71.66% ======================================= Files 19 19 Lines 1041 1041 ======================================= Hits 746 746 Misses 228 228 Partials 67 67
☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
bmoffatt
commented
Jan 7, 2022
LGTM, do you have an AWS docs link for this feature that I can reference?
rubengp99
commented
Jan 10, 2022
Can we cover custom SMS sender as well?
BorisLeMeec
commented
Jan 19, 2022
Sure, I will add the same for SMS, I have few time available atm, but asap.
@bmoffatt I'll add the link from documentation
hgpestana
commented
Apr 28, 2022
Hey, do you have any updates on this? @BorisLeMeec, do you need any help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs don't mention a returned response, I think the sender integration isn't quite the same as the Custom Message integration
Email Sender: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-email-sender.html
The custom code of your function must then process and deliver the message.
Compare with Custom Message Trigger: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html#cognito-user-pools-lambda-trigger-syntax-custom-message
In the response, specify the custom text to use in messages to your users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the response fields should be an empty object:
But the returned response is mentioned here: https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-working-with-lambda-triggers.html#working-with-lambda-trigger-sources
kmacmcfarlane
commented
Mar 6, 2023
Is this change still happening? Running into the need for the Email/SMS event models in a project I'm working on
Hey, @BorisLeMeec, @bmoffatt is there an update regarding the support for the custom email sender event? Are there any blockers for merging this?
MauritsBarendregt
commented
Jul 17, 2024
Bump, any updates on this one? Anyone uses a workaround?
yomipq
commented
May 12, 2025
Any updates?
Issue #, if available:
#370
Description of changes:
added new event struct for support of customEmailSender messages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.