-
-
Notifications
You must be signed in to change notification settings - Fork 68
Comments
Open
Conversation
Member
lepture
commented
Jul 29, 2019
Thanks. I would prefer to pass the base_url in a function instead of using os.environ. Check https://github.com/authlib/loginpass/blob/master/loginpass/gitlab.py as an example.
... B2Access and B2AccessDev instances are provided
Author
TomasKulhanek
commented
Jul 29, 2019
OK. Agree. I made update for default baseurl. This requires additional client code in case of non-default url, however, conforming the loginpass code style.
Member
lepture
commented
Jul 29, 2019
And also, can you provide a test case for it?
Author
TomasKulhanek
commented
Jul 31, 2019
Added test case for b2access and registered in init.py file
Author
TomasKulhanek
commented
Aug 28, 2019
The fork with this implementation of b2access is used in production for a month now without known problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B2ACCESS is an easy-to-use and secure Authentication and Authorization platform developed by EUDAT which delivers services for scientific, academia and research infrastructures cross border and cross discipline.
This PR adds oauth2 support for this service.