-
Notifications
You must be signed in to change notification settings - Fork 562
Conversation
@@ -1,5 +1,6 @@
import React from 'react';
import { mount } from 'enzyme';
import { render, screen } from '@testing-library/react';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Changes
Main object is to make auth0/lock compatible with react v19.
Primary change is to widen the react version in package.json to now support
^18.2.0 || ^19.0.0, this is being done to fix the issue where users are not able to run auth0/lock in react apps using v19 (Issue 2739).Other changes made are for upgrading the test suite to use react-testing-library in all the test files.
We had to migrate from enzyme to react-testing-library, since enzyme is not compatible with react 19 and there is no reliable adapter available as well.
References
The issue in question is here -> (Issue 2739)
Internal review doc -> here
Testing
Tested the new build in a sample-react app using vite as a bundler and all the green flows are working. Used it through both CDN and npm locally.
Checklist