Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Avoid default service crash without bundle identifier#336

Open
fhwvtqdc2q-svg wants to merge 2 commits into
auth0:master from
fhwvtqdc2q-svg:codex/safe-default-service
Open

Avoid default service crash without bundle identifier #336
fhwvtqdc2q-svg wants to merge 2 commits into
auth0:master from
fhwvtqdc2q-svg:codex/safe-default-service

Conversation

@fhwvtqdc2q-svg

@fhwvtqdc2q-svg fhwvtqdc2q-svg commented May 16, 2026
edited
Loading

Copy link
Copy Markdown

Summary

  • avoid force-unwrapping Bundle.main.bundleIdentifier for the default service value
  • fall back to SimpleKeychain when no bundle identifier is available
  • update the default initialization test for the fallback

Validation

  • Not run locally: Swift toolchain is not installed on this Windows machine.
  • Local checkout note: generated docs contain Windows-invalid paths, so the source was inspected from an archive excluding docs.

@fhwvtqdc2q-svg fhwvtqdc2q-svg requested a review from a team as a code owner May 16, 2026 05:26

Copy link
Copy Markdown
Contributor

Hi @fhwvtqdc2q-svg Thanks for raising the PR. We will check it shortly

@fhwvtqdc2q-svg fhwvtqdc2q-svg left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixe

Copy link
Copy Markdown
Contributor

@fhwvtqdc2q-svg commits need to be verified before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NandanPrabhu NandanPrabhu NandanPrabhu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /