Skip to content

Navigation Menu

Sign in
Sign up
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

update os matrix in ci - #2683

Merged
smashwilson merged 2 commits into
atom:master from
icecream17:update-ci
May 18, 2021
Merged

update os matrix in ci #2683
smashwilson merged 2 commits into
atom:master from
icecream17:update-ci

Conversation

@icecream17

@icecream17 icecream17 commented May 14, 2021

Copy link
Copy Markdown

which is currently ubuntu-18.05

See #2681 (comment)

which is currently `ubuntu-18.05`

Copy link
Copy Markdown
Author

oh wait, I accidentally did ubuntu instead of macOS

@icecream17 icecream17 changed the title (削除) bump to ubuntu-latest (削除ここまで) (追記) bump to macOS-latest (追記ここまで) May 14, 2021

Copy link
Copy Markdown
Contributor

oh wait, I accidentally did ubuntu instead of macOS

Would it be worthwhile to do both?

Copy link
Copy Markdown
Contributor

No idea what's going on with Actions here. It looks like all of the jobs are being instantly cancelled... ?

icecream17 commented May 14, 2021
edited
Loading

Copy link
Copy Markdown
Author
  1. Maybe the explicit version was kept for backwards compatibility??? If not, then I guess ubuntu could be updated as well
  2. https://github.community/t/github-actions-failed-due-to-internal-failure-how-to-rerun/18104 => https://www.githubstatus.com/, it seems like github actions is down or something

Copy link
Copy Markdown
Contributor

Yeah, I just saw the Actions outage right after I posted that, heh. I'll re-run once it's resolved to see how this does 🤞🏻

@icecream17 icecream17 changed the title (削除) bump to macOS-latest (削除ここまで) (追記) update os matrix in ci (追記ここまで) May 14, 2021

codecov Bot commented May 14, 2021
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2683 (592142f) into master (9e83fb4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #2683 +/- ##
==========================================
- Coverage 93.46% 93.46% -0.01% 
==========================================
 Files 237 237 
 Lines 13213 13213 
 Branches 1900 1900 
==========================================
- Hits 12350 12349 -1 
- Misses 863 864 +1 
Impacted Files Coverage Δ
lib/atom/gutter.js 90.47% <0.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e83fb4...592142f. Read the comment docs.

Copy link
Copy Markdown
Contributor

Alright, progress 👍🏻

The failure message on Windows makes me wonder if the Windows images have been changed to already include the build tools:

ERROR: Running ["C:\Users\runneradmin\AppData\Local\Temp\chocolatey\visualcpp-build-tools14円.0.25420.1\visualcppbuildtools_full.exe" -NoRestart -Quiet -Log "C:\Users\runneradmin\AppData\Local\Temp\chocolatey\visualcpp-build-tools.log" ] was not successful. Exit code was '1603'. Exit code indicates the following: Generic MSI Error. This is a local environment error, not an issue with a package or the MSI itself - it could mean a pending reboot is necessary prior to install or something else (like the same version is already installed). Please see MSI log if available. If not, try again adding '--install-arguments="'/l*v c:\visualcpp-build-tools_msi_install.log'"'. Then search the MSI Log for "Return Value 3" and look above that for the error..

The Ubuntu errors are more odd:

 1) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
 exec
 when the WorkerManager is not ready or disabled
 kills the git process when cancel is triggered by the prompt server:
 Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)
 
 2) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
 ssh authentication
 falls back to Atom credential prompts if SSH_ASKPASS is present but goes boom:
 Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)

These tests do rely on subprocess communication and have been flaky in the past, but never this flaky. I would worry a bit more that these are finding an actual bug (with newer Ubuntu versions maybe) but it isn't clear to me what that could be.

Copy link
Copy Markdown
Contributor

Let's merge this as-is to get some kind of green in our CI 😅 .

smashwilson merged commit 60f3918 into atom:master May 18, 2021
icecream17 deleted the update-ci branch September 7, 2021 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /