-
Notifications
You must be signed in to change notification settings - Fork 408
update os matrix in ci - #2683
Conversation
which is currently `ubuntu-18.05`
icecream17
commented
May 14, 2021
oh wait, I accidentally did ubuntu instead of macOS
smashwilson
commented
May 14, 2021
oh wait, I accidentally did ubuntu instead of macOS
Would it be worthwhile to do both?
smashwilson
commented
May 14, 2021
No idea what's going on with Actions here. It looks like all of the jobs are being instantly cancelled... ?
- Maybe the explicit version was kept for backwards compatibility??? If not, then I guess ubuntu could be updated as well
- https://github.community/t/github-actions-failed-due-to-internal-failure-how-to-rerun/18104 => https://www.githubstatus.com/, it seems like github actions is down or something
smashwilson
commented
May 14, 2021
Yeah, I just saw the Actions outage right after I posted that, heh. I'll re-run once it's resolved to see how this does 🤞🏻
Codecov Report
@@ Coverage Diff @@ ## master #2683 +/- ## ========================================== - Coverage 93.46% 93.46% -0.01% ========================================== Files 237 237 Lines 13213 13213 Branches 1900 1900 ========================================== - Hits 12350 12349 -1 - Misses 863 864 +1
Continue to review full report at Codecov.
|
smashwilson
commented
May 14, 2021
Alright, progress 👍🏻
The failure message on Windows makes me wonder if the Windows images have been changed to already include the build tools:
ERROR: Running ["C:\Users\runneradmin\AppData\Local\Temp\chocolatey\visualcpp-build-tools14円.0.25420.1\visualcppbuildtools_full.exe" -NoRestart -Quiet -Log "C:\Users\runneradmin\AppData\Local\Temp\chocolatey\visualcpp-build-tools.log" ] was not successful. Exit code was '1603'. Exit code indicates the following: Generic MSI Error. This is a local environment error, not an issue with a package or the MSI itself - it could mean a pending reboot is necessary prior to install or something else (like the same version is already installed). Please see MSI log if available. If not, try again adding '--install-arguments="'/l*v c:\visualcpp-build-tools_msi_install.log'"'. Then search the MSI Log for "Return Value 3" and look above that for the error..
The Ubuntu errors are more odd:
1) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
exec
when the WorkerManager is not ready or disabled
kills the git process when cancel is triggered by the prompt server:
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)
2) Git commands for CompositeGitStrategy made of [GitShellOutStrategy]
ssh authentication
falls back to Atom credential prompts if SSH_ASKPASS is present but goes boom:
Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/github/github/test/git-strategies.test.js)
These tests do rely on subprocess communication and have been flaky in the past, but never this flaky. I would worry a bit more that these are finding an actual bug (with newer Ubuntu versions maybe) but it isn't clear to me what that could be.
smashwilson
commented
May 18, 2021
Let's merge this as-is to get some kind of green in our CI 😅 .
which is currently
ubuntu-18.05See #2681 (comment)