Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix this bug#1155

Open
icecream17 wants to merge 2 commits intoatom:master from
icecream17:patch-1
Open

Fix this bug #1155
icecream17 wants to merge 2 commits intoatom:master from
icecream17:patch-1

Conversation

@icecream17
Copy link

@icecream17 icecream17 commented Sep 3, 2021

See 9da0512#commitcomment-55840601

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

The original code calls the function, instead of simply providing the function

Also based on the nearby functions, the functions need to be "bound" to the this value

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

icecream17 referenced this pull request Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sadick254 sadick254 sadick254 approved these changes

@detronetdip detronetdip detronetdip approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /