This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
Open
Conversation
This change causes find-and-replace to react instantly to keystrokes in the `findEditor` (the "Find in current buffer" field), rather than after a 300ms debounce delay.
@joliss
joliss
changed the title
(削除) Instantly update live search. (削除ここまで)
(追記) Instantly update live search (追記ここまで)
Aug 17, 2018
Contributor
Instant update feels good, but it makes typing noticably slower with many matches (e.g., 20 000). I think work needs to be put into handling the many matches case first, before this can be merged.
Alternatively:
-
There could be a mechanism to switch between delay and no delay, based on number of matches
-
A custom delay time could be used, so it's faster than
onDidStopChanging, which is used for more than just find and replace, but slow enough to let the user type.
Contributor
maxbrunsfeld
commented
Sep 11, 2018
I think that what we ultimately need to do is a two-step process:
- In an
onDidChangecallback, search the visible area. If there are no visible results after the cursor, find the next visible result for the purpose of supportingscrollToResultOnLiveSearch. - Then, in an
onDidStopChangingcallback, search the entire buffer, in order to compute the result count and theResult n of mmessage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description of the Change
This change causes find-and-replace to react instantly to keystrokes in the
findEditor(the "Find in current buffer" field), rather than after a 300ms debounce delay.This is especially important when the
scrollToResultOnLiveSearchsetting is enabled, as it lets you instantly see when you're at the right place in the file, just like when you search a web page in Chrome.Alternate Designs
One could make this behavior changeable with a setting. But I'm not sure if that's even necessary.
Benefits
Search feels snappier.
Possible Drawbacks
I haven't tested the performance impact of this with large buffers or on slower CPUs. We wouldn't want the editor to become unresponsive as you type into the search field.
Applicable Issues
When I tried running the test suite I had some failing tests on master, so I'm not sure if this broke any tests.