This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
HACK: Support eclipe.jdt.ls's break with the LSP spec #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could it be possible to add a command interface that ide-java can hook into on preinitialisation? Like this method but for commands.
As an aside, it seems they make decisions because "it works in VS Code", not because it conforms with the LSP spec. As such, I will now be referring to the Eclipse language server as a VS Code extension that happens to match some of the LSP. I was only half joking just then.
Sorry for the late reply. Yeah, I can add a hook, but the issue still is lack of context. I'll need at the minimum a way to apply a workspace edit from within ide-java.
hoihoi500
commented
Jun 9, 2020
Alles komt goed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather hacky hack to support eclipse.jdt.ls's custom
java.apply.workspaceEditcommand that they expect the client to handle.Originally I tried to implement a way for clients to specify which commands they wanted to handle as suggested in #183, but I ran into issues with being unable to actually follow through with the command. I can get the client to receive the command fine, but since all the logic is still in atom-languageclient, I can't hook into
applyWorkspaceEditor anything of the sort 😓. Maybe I'm missing something that would make this approach feasible?