-
Notifications
You must be signed in to change notification settings - Fork 265
Open
Conversation
@aminya
aminya
force-pushed
the
patch-3
branch
2 times, most recently
from
December 29, 2020 22:55
bac7224 to
afe6f9a
Compare
@aminya
aminya
force-pushed
the
patch-3
branch
from
December 29, 2020 23:25
afe6f9a to
66d3529
Compare
Member
*bump*
@aminya Any plans to merge this?
Member
aminya
commented
Jul 6, 2021
No as this breaks Python on Windows.
It would be better to use which to check if the executable is available and fallback to alternatives instead of failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.