Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Stabilize Future adapters and IntoFuture #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoshuawuyts wants to merge 1 commit into main
base: main
Choose a base branch
Loading
from stabilize-future-extensions

Conversation

Copy link
Contributor

@yoshuawuyts yoshuawuyts commented Sep 23, 2020

Stabilizes several stream adapters that have been proven over the last year. Also stabilizes IntoFuture. Thanks!

Changelog

## Changed
- `future::Future::delay` has been stabilized
- `future::Future::flatten` has been stabilized
- `future::Future::race` has been stabilized
- `future::Future::try_race` has been stabilized
- `future::Future::join` has been stabilized
- `future::Future::try_join` has been stabilized
- `future::Future::timeout` has been stabilized
- `future::Future::delay` has been stabilized
- `future::IntoFuture` has been stabilized

Copy link
Contributor Author

CI is failing because of #883

Copy link
Member

Keruspe commented Sep 24, 2020

Btw, should we switch to libstd's IntoFuture or would that be breaking?

//! [`Future::try_race`]: trait.Future.html#method.try_race
cfg_alloc! {
pub use into_future::IntoFuture;
Copy link
Contributor

@taiki-e taiki-e Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you plan to replace this with re-export of std IntoFuture when std IntoFuture's is stable, that would be a breaking change. IIUC, theoretically, there is a way to avoid almost breakage. See rust-lang/futures-rs#2207 and https://github.com/taiki-e/futures-compat-experiment for that.

yoshuawuyts reacted with thumbs up emoji
Copy link
Member

@yoshuawuyts these CI failures look somewhat real to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire Awaiting requested review from dignifiedquire

1 more reviewer

@taiki-e taiki-e taiki-e left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /