-
Notifications
You must be signed in to change notification settings - Fork 343
Enforce non zero capacity for channel #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this fails in quite a few places but I don't think those failures are related to my changes
I've been doing some thinking and perhaps instead of guarding against zero we could use the type checker to make sure that we never get zero by using NonZeroUsize what do you think?
ah strike that, it requires to be manually wrapped, however, it could be used for the internal functions? as in the Channel struct
this fails in quite a few places but I don't think those failures are related to my changes
I think it can be fixed by rebase master.
Co-Authored-By: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
d181398 to
3004312
Compare
Sorry for the late reply / rebase, got dragged into $otherrthings TM️
This aligns the function with it's documentation and will result in easier to resolve errors for problems such as #712.
closes #712