-
Notifications
You must be signed in to change notification settings - Fork 343
Some functions in future module to no_std #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7eaa87 to
3883079
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm so-so about this change. Functions such as io::copy don't work on no-std either, but would be really useful to have as well. Having these functions be async fn was a bit of a deliberate choice when designing async-std.
With async await for embedded rust steadily progressing, I wonder how needed this is. It seems as async/await continues to move beyond mvp status this will be much of a non-issue.
All in all I think it'd be okay to leave these methods as-is for now. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the feature won't make the cut in 6 days, so it's at least 18 weeks out. Given that this is no user-visible change, I'd be fine with enabling embrio users to use this currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the interface seen from the user does not change, I think that it is OK to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ready should be able to work in no-std.
Uh oh!
There was an error while loading. Please reload this page.
Some functions in future module to no_std