-
Notifications
You must be signed in to change notification settings - Fork 343
Add context to more errors #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18cbf4a to
e01f07d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really good work!
Left a few commends regarding capitalization. Std doesn't capitalize errors, so probably neither should we (and at the very least we should be consistent).
Also left a few comments where it'd be nice to know which addresses we couldn't resolve. Unsure if we can retrieve that information, but if we can that'd be 💯.
Thanks so much; looking forward to this patch!
Co-Authored-By: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
71e626a to
94791c8
Compare
Moves the point of adding error context to the net::addr module so that we have access to the raw address input and can include it in the error message.
94791c8 to
56538eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent; thanks so much!
Pretty mechanical additions and by no means exhaustive: I bascially just wanted to cover the APIs I end up using quite often :)
For a future PR it might be interesting to add a test that shows that our errors include the correct sources, and that they might even work well with std backtraces.
cc #569