-
Notifications
You must be signed in to change notification settings - Fork 343
Fix book to use futures_channel and futures_util, re-enable testing #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: These dependencies are indirect, and come from this line in the Cargo.toml:
[dev-dependencies.futures-preview] version = "0.3.0-alpha.18" features = ["std", "nightly", "async-await"]
I'm not sure the best way to access these NOT indirectly. I think futures-preview is aliasing with futures v0.1.29 from this part of the dependency tree:
├── futures-timer v0.4.0
│ ├── futures-core-preview v0.3.0-alpha.18 (*)
│ ├── futures-util-preview v0.3.0-alpha.18
│ │ ├── futures v0.1.29
Possibly related to rust-lang/mdBook#706
Okay, I went ahead and just added these as explicit dev-dependencies, and added a comment in Cargo.toml what they were used for. Hopefully this will give some context for later refactorings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thanks for doing this!
Closes #158