-
Notifications
You must be signed in to change notification settings - Fork 343
Rename server functions to follow *_loop convention #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...er -> connection_writer_loop
changes look good to me, @kachayev could you resolve the merge conflcts?
@kachayev hi, just checking in on this patch. This seems like something we'd definitely want to merge; do you think you can get around to rebasing? We'd appreciate it a lot!
@yoshuawuyts Oh, sorry for the delay 🤦♂ Will do it shortly!
@yoshuawuyts Seems good now!
Looks like there's still come compilation errors: https://travis-ci.com/async-rs/async-std/jobs/237256929
@yoshuawuyts Compiles now ;)
Great, thanks for following up here @kachayev !
Follow up on async-rs/a-chat#7.
Covers #106.
Hope I didn't miss anything.