-
Notifications
You must be signed in to change notification settings - Fork 343
Implement installation using trust #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regarding the removal of cargo-install-update: It seemed to only serve to update mdbook (see context here), and trust will install the newest version always anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This env was replaced if one is defined in the matrix. This meant that previously this flag was only set on Windows builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![[ is treated differently than ! [[. The latter is what we wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we have semver expectations for the book, but this matches the previous behavior of --version "^0.3"
Looks good to me!
Uh oh!
There was an error while loading. Please reload this page.
Closes #115