-
Notifications
You must be signed in to change notification settings - Fork 62
feat: keep requests under the endpoint byte limit by stripping oldest images#281
Open
mlikasam-askui wants to merge 2 commits into
Open
feat: keep requests under the endpoint byte limit by stripping oldest images #281mlikasam-askui wants to merge 2 commits into
mlikasam-askui wants to merge 2 commits into
Conversation
@mlikasam-askui
mlikasam-askui
requested review from
philipph-askui and
programminx-askui
June 2, 2026 14:56
programminx-askui
programminx-askui
requested changes
Jun 3, 2026
provider_options: dict[str, Any] | None = None,
) -> MessageParam:
estimated_bytes = estimate_messages_bytes(messages)
if estimated_bytes > ANTHROPIC_MAX_REQUEST_BYTES:
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we estimate the Request side. I would prefere to deal with the Error. And then do the Truncation strategy.
Otherwise we don't know if the LLM Provider is inceasing theire 30 MB Limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Strip oldest base64 images from history when a request would exceed the endpoint's ~30 MB byte limit. Adds request-size estimation, a per-provider
max_request_bytes, and budget enforcement inSummarizingTruncationStrategy(skipped when no limit is defined).Jira: SOLENG-369