Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WIP]🚧 Storybooks Integration #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
AuraOfDivinity wants to merge 8 commits into asgardeo:main
base: main
Choose a base branch
Loading
from AuraOfDivinity:storybooks-integration

Conversation

@AuraOfDivinity
Copy link

@AuraOfDivinity AuraOfDivinity commented Oct 10, 2025
edited
Loading

Purpose

This pull request integrates Storybooks. PR will be updated to include additional details as more changes are made.

Related Issues

Checklist

  • Install and configure Storybook core dependencies, React and Vite integrations in the monorepo
  • Add essential Storybook addons (essentials, a11y, Chromatic, design tokens, docs, controls, viewport)
  • Set up .storybook configuration for @asgardeo/react
  • Set up .storybook configuration for @asgardeo/nextjs
  • Ensure compatibility with React and Next.js components (alias resolution, framework integration)
  • Add .stories.tsx files for key components (e.g., OrganizationSwitcher, CreateOrganization) covering various states (default, loading, error)
  • Document component props, API usage, and interactive examples in stories
  • Integrate existing i18n system (packages/javascript/src/i18n/) and enable locale switching in Storybook
  • Configure accessibility and visual regression testing (a11y addon, Chromatic setup)
  • Add Storybook scripts to package.json and configure static build output for deployment
  • Validate builds locally and in CI/CD (storybook build + Chromatic run)
  • Update documentation/README with Storybook usage and testing workflow
  • Verify design consistency, accessibility, and final deliverables before merging

Security checks

},
"plugins": []
} No newline at end of file
"plugins": [
Copy link
Member

@brionmario brionmario Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer not to use nx for anything other than build caching.
Shall we use the standalone storybook instead.

Copy link
Member

@brionmario brionmario Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever the new packages we introduce (storybook related) should be in the react package's package.json.

"next": "^15.3.2",
"prettier": "^2.6.2",
"react": "^19.1.0",
"react": "^19.2.0",
Copy link
Member

@brionmario brionmario Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for bumping the React version?

@@ -0,0 +1,25 @@
import type {StorybookConfig} from '@storybook/react-vite';
Copy link
Member

@brionmario brionmario Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add out license header to all the newly added files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brionmario brionmario brionmario left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /