Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix auto-closing if used in open shadow DOM #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soldag wants to merge 1 commit into arthurdenner:develop
base: develop
Choose a base branch
Loading
from soldag:shadow-dom

Conversation

Copy link

@soldag soldag commented May 28, 2024

What kind of change does this PR introduce?

Fixes auto-closing of the calendar popup when the component is used in an open shadow DOM.

What is the current behavior?
When the component is used in an open shadow DOM, the popup is closed on any click, no matter whether it's in the popup or not.

What is the new behavior?
The popup is closed only if the user has clicked outside of the popup.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Copy link

vercel bot commented May 28, 2024
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-semantic-ui-datepickers ❌ Failed (Inspect) May 28, 2024 11:37am

Copy link
Author

soldag commented May 28, 2024

I wasn't sure if this project is still maintained, so I didn't want to put too much effort in this. If needed, I can add tests.

Copy link
Owner

I wasn't sure if this project is still maintained, so I didn't want to put too much effort in this. If needed, I can add tests.

I have zero time to maintain this project nor I use it anymore, so my suggestion is to fork it and use your fork instead. The project has a MIT license so you're fine to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /